Add a test command #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
requested changes
Aug 7, 2018
| @@ -5,7 +5,7 @@ | |||
| <name>Sentry</name> | |||
| <summary>Sentry client</summary> | |||
| <description>A Sentry integration that sends unhandled exceptions to a Sentry instance to aggregate application crashes. You either have to set up your own Sentry instance or use your sentry.io account. See the admin documentation for how to configure this app.</description> | |||
| <version>3.0.0</version> | |||
There was a problem hiding this comment.
This should be a minor version bump according to semver.
| public function execute(InputInterface $input, OutputInterface $output) { | ||
| try { | ||
| throw new \Exception('This is a sentry test exception!'); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Since you're catching the exception every time, wouldn't it just make sense to directly log it? Or does that make any difference for the report (stack trace missing or whatsoever)?
There was a problem hiding this comment.
Yeah the trace is a bit neater this way.
There was a problem hiding this comment.
Really? Because the trace is generated on the new \Exception() and thus should not be much different, or am I totally wrong?
There was a problem hiding this comment.
@MorrisJobke it is because it is still on my list to have some options to the command as well. So you get test with the log levels and all that.
Fixes #27 Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
feature/27/add_test_command
branch
from
e2559cb
to
20107e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Signed-off-by: Roeland Jago Douma [email protected]