Add JavaScript error report #22
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
|
Wouldn't it be easiest to just have a simple controller that just proxies the stuff to sentry? That way you get around the CSP ;) |
|
Else you can of course when this app is enabled just add a policy to the CSP see https://github.com/nextcloud/files_texteditor/blob/master/appinfo/app.php#L14 |
I think there's a lot of dark magic in the Sentry client to gather lots of information about the error and the browser for the report. I'd have to implement all that by myself. |
|
Ah the just extend the CSP when this app is enabled ;) |
|
Will do, thanks for the tip! |
…nto feature/javascript-error-report Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
changed the title
|
CSP is fixed now. @rullzer @georgehrke @MorrisJobke give this a quick review please :) |
Signed-off-by: Christoph Wurst <[email protected]>
| * @NoCSRFRequired | ||
| */ | ||
| public function dsn(): Response { | ||
| $pubDsn = $this->config->getSystemValue('sentry.public-dsn', null); |
There was a problem hiding this comment.
This should be documented in the readme and maybe also add a link to https://docs.sentry.io/clients/javascript/usage/#preventing-abuse there.
There was a problem hiding this comment.
Good catch! I fixed it in the latest commit.
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Fixes #20
Todo:
cc @georgehrke