Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed kamap #10

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Removed kamap #10

merged 1 commit into from
Nov 21, 2023

Conversation

robdahn
Copy link
Collaborator

@robdahn robdahn commented Nov 21, 2023

Removed kamap segmentation that was introduced in 2019 as alternative to the SPM unified segmentation but never really used. Removed the cat_main_kamap functions and its calls from cat_main[1639], cat_main_updateSPM[1639], cat_main_reportstring, and the definition of the extopts.segmentation.spm_kamap parameter from cat_conf_extopts and standalone scripts. Keep the enhanced cleanup option in cat_main_clean_gwc[1639] as it is also used for T2/PD images.

Removed kamap segmentation that was introduced in 2019 as alternative to the SPM unified segmentation but never really used. Removed the cat_main_kamap functions and its calls from cat_main[1639], cat_main_updateSPM[1639], cat_main_reportstring, and the definition of the extopts.segmentation.spm_kamap parameter from cat_conf_extopts and standalone scripts.  Keep the enhanced cleanup option in cat_main_clean_gwc[1639] as it is also used for T2/PD images.
@robdahn robdahn added the Cleanup Removing of old/unused/unfinished functions label Nov 21, 2023
@robdahn robdahn self-assigned this Nov 21, 2023
@robdahn robdahn linked an issue Nov 21, 2023 that may be closed by this pull request
12 tasks
@ChristianGaser
Copy link
Owner

ChristianGaser commented Nov 21, 2023 via email

@robdahn
Copy link
Collaborator Author

robdahn commented Nov 21, 2023

The MRF AMAP parameter is not related to these parameter/function.

I also ran additional testes SPM and CAT restarts (default+expert+developer) and cross-sectional segmented a 2 mm image to test changes in the CAT report.

@robdahn robdahn merged commit 0b4d9ac into main Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Removing of old/unused/unfinished functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup 2023
2 participants