This repository has been archived by the owner on Mar 7, 2020. It is now read-only.
Mal 46/show opensource libraries #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the old plugin used to display licenses, and instead add the dependency from https://github.com/mikepenz/AboutLibraries to use the new way to show license information.
Add item in the settings that allows user to view the open source software licenses that are used in the application.
ChesireBot
reviewed
Jan 17, 2019
| @@ -101,4 +101,9 @@ | |||
| <string name="search_add_failed">Failed to add %s, please try again</string> | |||
| <string name="search_failed_general_error">Search failed, please try again</string> | |||
| <string name="search_failed_no_items">No items found</string> | |||
|
|
|||
| <string name="aboutLibraries_description_title">Malime licenses</string> | |||
| <string name="aboutLibraries_description_showIcon">true</string> | |||
There was a problem hiding this comment.
The resource R.string.aboutLibraries_description_showIcon appears to be unused |
ChesireBot
reviewed
Jan 17, 2019
|
|
||
| <string name="aboutLibraries_description_title">Malime licenses</string> | ||
| <string name="aboutLibraries_description_showIcon">true</string> | ||
| <string name="aboutLibraries_description_showVersion">true</string> |
There was a problem hiding this comment.
The resource R.string.aboutLibraries_description_showVersion appears to be unused |
ChesireBot
reviewed
Jan 17, 2019
| <string name="aboutLibraries_description_title">Malime licenses</string> | ||
| <string name="aboutLibraries_description_showIcon">true</string> | ||
| <string name="aboutLibraries_description_showVersion">true</string> | ||
| <string name="aboutLibraries_description_text">Malime was created using many popular third party open source libraries, and is open source itself. The source code is available at https://github.com/Chesire/Malime</string> |
There was a problem hiding this comment.
The resource R.string.aboutLibraries_description_text appears to be unused |
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
============================================
- Coverage 19.39% 19.31% -0.09%
Complexity 144 144
============================================
Files 73 73
Lines 1913 1921 +8
Branches 221 221
============================================
Hits 371 371
- Misses 1538 1546 +8
Partials 4 4
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.