macOS update checker fix #1642
Merged
macOS update checker fix #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On macOS, checking the web API for an update would always result in the "Failed to load version information" message. Also, the update message dialog could sometimes be off-screen to the left making the message unreadable.
Chatterino expected a JSON field "portable_download" for both Windows and macOS, but the web API only provides that field for the
/win/endpoint. This results in macOS Chatterino always complaining that it couldn't check for an update.Screenshot before:
Screenshot after: (I locally bumped version to test)
