Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Implemented log_to_file_ex & fixes #262

Merged
merged 10 commits into from
Mar 7, 2022
Merged

Core: Implemented log_to_file_ex & fixes #262

merged 10 commits into from
Mar 7, 2022

Conversation

ShadowsAdi
Copy link
Contributor

@ShadowsAdi ShadowsAdi commented Mar 6, 2022 •
edited by wopox1337
Loading

Fix #249
fix #207

@wopox1337 wopox1337 self-requested a review March 6, 2022 19:34
@wopox1337 wopox1337 added the bug Something isn't working label Mar 6, 2022
@wopox1337 wopox1337 added this to the 📝 Release v1.8 milestone Mar 6, 2022
Nord1cWarr1or
Nord1cWarr1or requested changes Mar 7, 2022
View reviewed changes
Copy link
Collaborator

@Nord1cWarr1or Nord1cWarr1or left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the style of the braces like in a whole project

if(cond) 
{
...
}

->

if(cond) {
...
}

@JUNESYNGOTOFLEX
Copy link
Contributor

JUNESYNGOTOFLEX commented Mar 7, 2022 •
edited
Loading

мне кажется это должен делать создатель ресурса

@wopox1337
Copy link
Collaborator

@ShadowsAdi I propose to make this option a separate one.
Suppose ca_log_type 3

@wopox1337 wopox1337 added this to In progress in Feature requests via automation Mar 7, 2022
@wopox1337 wopox1337 changed the title Core: Implemented log_to_file_ex Core: Implemented log_to_file_ex & fixes Mar 7, 2022
@wopox1337 wopox1337 merged commit 3a7dc2b into ChatAdditions:master Mar 7, 2022
Feature requests automation moved this from In progress to Done Mar 7, 2022
@ShadowsAdi ShadowsAdi deleted the add-core-log_to_file_ex branch March 7, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nord1cWarr1or Nord1cWarr1or Nord1cWarr1or requested changes

@wopox1337 wopox1337 wopox1337 approved these changes

Assignees

@ShadowsAdi ShadowsAdi

Labels
bug Something isn't working
Projects
Feature requests
  
Done
Milestone
📝 Release v1.8
Development

Successfully merging this pull request may close these issues.

log_to_file prints all logs to console ca_log_type 0 creates folder ChatAdditions/ but logs to common file
4 participants
@ShadowsAdi @JUNESYNGOTOFLEX @wopox1337 @Nord1cWarr1or