Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenspacecontroller support for cesium unreal #1449

Closed

Conversation

jiangheng90
Copy link

@jiangheng90 jiangheng90 commented Jun 9, 2024

fullfill the feature from community

@jiangheng90 jiangheng90 changed the title support screenspace controller for cesium unreal screenspacecontroller support for cesium unreal Jun 9, 2024
Copy link
Author

@jiangheng90 jiangheng90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after CHANGES.md update I will add the Additions

@jiangheng90
Copy link
Author

the globe pawn is support the full feature when georeference origin placement in true origin,in cartographic some feature is disabled. Use the quick add panel. It will add in proper place.

@FEJackFly
Copy link

When is it online? It's urgent

@chenguang1994
Copy link

expect

@LuLuEarl
Copy link

The operation is smooth,Thank you for sharing

@j9liu j9liu linked an issue Jun 27, 2024 that may be closed by this pull request
@jiangheng90
Copy link
Author

@j9liu I have looked issue u link. so what do we need to do to make this move forward?

@j9liu
Copy link
Contributor

j9liu commented Jun 28, 2024

Hey @jiangheng90, I did that while trying to organize PRs / issues in this repo. We have some things that we're trying to get done before the release next week, but we'll review this as soon as we can. Thank you for your patience 🙏

@FEJackFly
Copy link

image

What should I do when generating a solution and reporting error MSB307 is reported

ue 5.3
Visual Studio 2022
cmake 3.30

@pjiang9
Copy link

pjiang9 commented Jul 31, 2024

@jiangheng90
Thank you for fulfilling the GlobePawn!
Yet there are situations that will make Unreal Engine Crash.
It is hard to describe how to reproduce the crash situations.
It is likely to crash when zoom in and zoom out several times, and the viewport will be complete black, then UE will shut down.
The following is the log captured when UE crashes. Much appreciated if you could look into it and fix it.

UE5.3,CesiumforUnreal2.5.0
UnrealEditor_CesiumRuntime!CesiumGeometry::Plane::Plane()
UnrealEditor_CesiumRuntime!Cesium3DTilesSelection::createCullingVolume()
UnrealEditor_CesiumRuntime!Cesium3DTilesSelection::ViewState::create()
UnrealEditor_CesiumRuntime!ACesium3DTileset::CreateViewStateFromViewParameters() [E:\UnrealPack\CesiumforUE\UE_5.3\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\Cesium3DTileset.cpp:1673]
UnrealEditor_CesiumRuntime!ACesium3DTileset::Tick() [E:\UnrealPack\CesiumforUE\UE_5.3\CesiumForUnreal\HostProject\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\Cesium3DTileset.cpp:2123]
UnrealEditor_Engine

UE5.3 CesiumforUnreal2.7.0
UnrealEditor_CesiumRuntime!Cesium3DTilesSelection::createCullingVolume()
UnrealEditor_CesiumRuntime!Cesium3DTilesSelection::ViewState::create()
UnrealEditor_CesiumRuntime!ACesium3DTileset::CreateViewStateFromViewParameters() [E:\UE53Projects\GlobePawn\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\Cesium3DTileset.cpp:1630]
UnrealEditor_CesiumRuntime!ACesium3DTileset::Tick() [E:\UE53Projects\GlobePawn\Plugins\CesiumForUnreal\Source\CesiumRuntime\Private\Cesium3DTileset.cpp:2082]

@andiven
Copy link

andiven commented Jul 31, 2024

@jiangheng90 I hope Touch support can be added.

@jiangheng90 jiangheng90 deleted the screen_space_controller branch July 31, 2024 15:40
@kring
Copy link
Member

kring commented Aug 2, 2024

Hi @jiangheng90, sorry to see you close this. We've been slow to review it, but it's definitely a valuable contribution!

@zzzsssddd999
Copy link

GlobePawn有BUG,用这个后,操作时UE编辑器运行窗口会突然黑屏,然后UE编辑器会崩溃(在编辑器运行后操作最多20分钟必出,该BUG概率挺高,最快可能1分钟就崩溃),UE5.3,在cesium unreal2.5,2.7版本都存在。换回cesium unreal自带的DynamicPawn再怎么操作都不会黑屏崩溃。

@jiangheng90
Copy link
Author

jiangheng90 commented Aug 2, 2024

@kring I'm sorry for the pull request close.

It's been more than half a year since the end of development of this feature, and many of the technical details in it are not so familiar to me now.

Secondly, because of the development of this feature, some people found my social accounts and caused some trouble to my privacy, which I didn't want.

Right now, can u just make a feature branch and I make my pull request to this branch. it will take a long time to make this feature be all right and I think this is a better way for both of us to push it forward.

@kring
Copy link
Member

kring commented Aug 5, 2024

It's been more than half a year since the end of development of this feature, and many of the technical details in it are not so familiar to me now.

Understood. It's only been a couple of months since you opened the PR, but even that is too long.

Secondly, because of the development of this feature, some people found my social accounts and caused some trouble to my privacy, which I didn't want.

Oh no, really sorry that's happening to you. That sort of behavior definitely has no place in the Cesium community. Let us know if we can help in any way.

Right now, can u just make a feature branch and I make my pull request to this branch. it will take a long time to make this feature be all right and I think this is a better way for both of us to push it forward.

Ok, I created a branch called screen-space-controller in this repo. It's just a copy of main.

@jiangheng90
Copy link
Author

@kring I have all ready make a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mouse-Based Player Controls
9 participants