Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-73 Add camera picture to screenshot #5006

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Jr9992
Copy link
Contributor

@Jr9992 Jr9992 commented Jun 27, 2024

Merges camera picture into screenshot if screenshot is taken while the camera is active.

  • add ScreenshotUtils.kt
  • change logic in ScreenshotSaver.kt
  • add functions to CameraManager.kt
  • add logic to StageActivity.java
  • add logic to StageListener.java
  • change ScreenshotSaverTest.kt

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Jr9992 Jr9992 marked this pull request as ready for review June 27, 2024 17:00
# Conflicts:
#	catroid/src/main/java/org/catrobat/catroid/stage/StageActivity.java
@coki1405 coki1405 self-requested a review August 7, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants