[pull] master from audacious-media-player:master #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
Pull request analysis by VIZIPI Below you will find who is the most qualified team member to review your code. Reviewers with knowledge related to these changes
Potential missing files from this Pull requestfiles commonly committed with a subset of this pr, but not committed this time. (click to collapse)
Committed file ranks(click to expand)0.00%[src/libaudqt/fileopener.cc] 70.00%[src/libaudqt/audqt.cc] 0.00%[src/libaudqt/log-inspector.cc] 0.00%[src/libaudqt/font-entry.cc] 0.00%[src/libaudqt/libaudqt-internal.h] 95.00%[src/libaudcore/tests/test.cc] 0.00%[contrib/audacious.appdata.xml] 0.00%[src/libaudcore/tuple.h] 0.00%[mkrelease.sh] 0.00%[src/libaudqt/queue-manager-qt.cc] |
Hard-Coded Secrets (2)Line 1091 in 4144b73 Line 1086 in 4144b73 More info on how to fix Hard-Coded Secrets in General. Insecure Use of Dangerous Function (2)audacious/src/audacious/main.cc Line 440 in 4144b73 audacious/src/libaudqt/audqt.cc Line 60 in 4144b73 More info on how to fix Insecure Use of Dangerous Function in C. Insecure Processing of Data (1)audacious/src/audacious/main.cc Line 284 in 4144b73 More info on how to fix Insecure Processing of Data in C. 👉 Go to the dashboard for detailed results. 📥 Happy? Share your feedback with us. |
ArchiveReader does not appear to be used anywhere yet.
This was the case before f3cc059 and also matches the GTK behavior.
Backport of commit 2466c33.
Backport of commit b600b71.
qtui's MainWindow wants to call unregister_dock_host() early for a clean teardown before being destroyed, but should still call it in the destructor anyway to be sure. Making it safe to call twice does no harm and saves logic on the qtui side.
No longer needed; the qtui change was reverted. This reverts commit bb05a71.
It is used in libaudcore's scan_plugin_func().
Fixes a crash that can occur due to QEvents being unexpectedly deleted when an extra audqt::init() + cleanup() pair is called at startup, as when the skins-qt plugin fails to load.
If not installed, Audacious does neither show SVG icons nor our logo in the about dialog. It also gives package maintainers a clear indicator that Audacious depends on it at runtime.
Without a parent, the popup is always shown at the top left corner instead of near the cursor (when using Wayland). It also avoids the following warning: "Window 0xabcd is a temporary window without parent, application will not be able to position it on screen." See also: https://docs.gtk.org/gtk3/method.Window.set_transient_for.html
Now mandatory for Flathub build, see: https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-developer-name Signed-off-by: Artem Polishchuk <[email protected]>
Better to print a warning than fail to start completely on pure Wayland.
We require only Qt 5.2 but qEnvironmentVariable() needs Qt >= 5.10.
Buildsys no longer hardcodes it to 0 and doesn't use a fallback value. See also: https://fl.nil.im/buildsys/vinfo/56ccacdc62ad446c
Set LIB_PATCH in makefiles for correct SONAMEs. Closes: #1408
Calling both gtk_drag_get_data() and gtk_drag_finish() leads to drag and drop not working on Wayland and this error: "error reading selection buffer: Operation was cancelled" Move the gtk_drag_finish() call to the "drag-data-received" handler which gets triggered by calling gtk_drag_get_data() to fix this. See also: - https://gitlab.gnome.org/GNOME/gimp/-/merge_requests/927 - https://docs.gtk.org/gtk3/signal.Widget.drag-drop.html Co-authored-by: John Lindgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )