Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrofit Client in common Folder #14

Closed
Canato opened this issue Aug 31, 2020 · 0 comments · Fixed by #16
Closed

Retrofit Client in common Folder #14

Canato opened this issue Aug 31, 2020 · 0 comments · Fixed by #16
Projects
BreakingBadFeat Project Settings LeaderBoard

Comments

@Canato
Copy link
Owner

Canato commented Aug 31, 2020

Inside Common module create a Common class that instance the retrofit client.

Ideally give to option to instantiate it with different urls
@Canato Canato added this to To do in Project Settings via automation Aug 31, 2020
@Canato Canato added this to To do in LeaderBoard via automation Aug 31, 2020
@Canato Canato added this to To do in BreakingBadFeat via automation Aug 31, 2020
Canato added a commit that referenced this issue Aug 31, 2020
@Canato
close #14
309cd04
@Canato Canato linked a pull request Aug 31, 2020 that will close this issue
Feature/#14 common retrofit client #16
Merged
@Canato Canato closed this as completed in #16 Sep 1, 2020
BreakingBadFeat automation moved this from To do to Done Sep 1, 2020
Project Settings automation moved this from To do to Done Sep 1, 2020
Canato added a commit that referenced this issue Sep 1, 2020
@Canato
Feature/#14 common retrofit client (#16)
f42bdb8 
* close #14

* add retrofit library and import

* change project import to project style

* update Changelog

* [KtLint-Bot]: Fixing your shit code
LeaderBoard automation moved this from To do to Done Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
BreakingBadFeat
  
Done
LeaderBoard
  
Done
Project Settings
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#14 common retrofit client Canato/showcase
1 participant
@Canato