-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document first authors #8
Conversation
…utions between Sanchez-Pinto and Bennet; DeWitt and Russell. Prior to this change all the references where just copied from the "Cite This" provided on the JAMA website. This change add Russell explicitly and asstricks and a note about the contributions. The language is copied form the JAMA paper as well. There is one exception - the DESCRIPTION file does not have these indicators for contribution levels. re #7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 176 176
=========================================
Hits 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi Peter - it looks like the mentions of the manuscripts in the README still need to be updated. thanks |
@tdbennett I've added asterisks to our names in the README |
@@ -15,9 +15,11 @@ | |||
Implementation of the Phoenix and Phoenix-8 Sepsis Criteria as | |||
described in: | |||
|
|||
* ["Development and Validation of the Phoenix Criteria for Pediatric Sepsis and Septic Shock"](doi:10.1001/jama.2024.0196) by Sanchez-Pinto, Bennett, DeWitt, Russell et.al. (2024) | |||
* ["Development and Validation of the Phoenix Criteria for Pediatric Sepsis and Septic Shock"](doi:10.1001/jama.2024.0196) by Sanchez-Pinto*, Bennett*, DeWitt**, Russell** et al. (2024) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdbennett this should render well. I used the html code *
to avoid markdown formatting conflicts
Refactor how the two JAMA papers are cited - all the authors and equal contribution notes are in the phoenix-package documentation with links and directions to review the details there in all the other function manual files. The CITATION file as been extended to include notes on the two JAMA papers and instructions on how to cite the R package. re #7, #8
@tdbennett, I've added notes for equal contribution for you and Nelson, along with a similar not for Seth and I. Please review.
There is one exception. I didn't add any note within the Description section of the DESCRIPTION file. To add the note there I would think a parenthetical would be better than just astriks.
I've opted to use the term "contributed equally" instead of co-first-author or co-second-author to be consistent with the language used by JAMA.