Document first authors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utions between Sanchez-Pinto and Bennet; DeWitt and Russell. Prior to this change all the references where just copied from the "Cite This" provided on the JAMA website. This change add Russell explicitly and asstricks and a note about the contributions. The language is copied form the JAMA paper as well. There is one exception - the DESCRIPTION file does not have these indicators for contribution levels. re #7
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 176 176
=========================================
Hits 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi Peter - it looks like the mentions of the manuscripts in the README still need to be updated. thanks |
|
@tdbennett I've added asterisks to our names in the README |
dewittpe
commented
Mar 4, 2024
| @@ -15,9 +15,11 @@ | |||
| Implementation of the Phoenix and Phoenix-8 Sepsis Criteria as | |||
| described in: | |||
|
|
|||
| * ["Development and Validation of the Phoenix Criteria for Pediatric Sepsis and Septic Shock"](doi:10.1001/jama.2024.0196) by Sanchez-Pinto, Bennett, DeWitt, Russell et.al. (2024) | |||
| * ["Development and Validation of the Phoenix Criteria for Pediatric Sepsis and Septic Shock"](doi:10.1001/jama.2024.0196) by Sanchez-Pinto*, Bennett*, DeWitt**, Russell** et al. (2024) | |||
There was a problem hiding this comment.
@tdbennett this should render well. I used the html code * to avoid markdown formatting conflicts
Closed
Refactor how the two JAMA papers are cited - all the authors and equal contribution notes are in the phoenix-package documentation with links and directions to review the details there in all the other function manual files. The CITATION file as been extended to include notes on the two JAMA papers and instructions on how to cite the R package. re #7, #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tdbennett, I've added notes for equal contribution for you and Nelson, along with a similar not for Seth and I. Please review.
There is one exception. I didn't add any note within the Description section of the DESCRIPTION file. To add the note there I would think a parenthetical would be better than just astriks.
I've opted to use the term "contributed equally" instead of co-first-author or co-second-author to be consistent with the language used by JAMA.