Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix wheels upload on different dir #590

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

Fixes the fix from #587.

I edited the workflow to run in the PR, so we can test it works (without an api key)

Closes #586

@aborgna-q
Copy link
Collaborator Author

This should work now. The workflow succeeded up to actually trying to upload to pypi (and failed due to the missing api token)
https://github.com/CQCL/tket2/actions/runs/10720469490/job/29727314966?pr=590#step:3:46

@aborgna-q aborgna-q marked this pull request as ready for review September 5, 2024 12:51
@aborgna-q aborgna-q requested a review from a team as a code owner September 5, 2024 12:51
Copy link
Contributor

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing and clearly explaining this.

@aborgna-q aborgna-q added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit 09a7b8b Sep 5, 2024
12 checks passed
@aborgna-q aborgna-q deleted the ab/really-fix-wheels-name branch September 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Wheels publish job failed due to project name
2 participants