Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 209 static backup HTML rendering & Jupyter sub-module #216

Merged
merged 12 commits into from
Jul 8, 2021

Conversation

PokkeFe
Copy link
Collaborator

@PokkeFe PokkeFe commented Jul 1, 2021

Added static backup HTML for notebook viewers without JS support and saved notebooks.

Also broke out jupyter.py into a sub-module and separated exposed functions into different script files.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@PokkeFe PokkeFe marked this pull request as ready for review July 7, 2021 21:40
@frreiss
Copy link
Member

frreiss commented Jul 7, 2021

@PokkeFe can you please pull the latest changes from the master branch to get the tests working again on this branch?

Copy link
Member

@frreiss frreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frreiss frreiss merged commit 89d93e2 into CODAIT:master Jul 8, 2021
@PokkeFe PokkeFe deleted the issue-209-static-backup branch July 20, 2021 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants