SpanArray HTML rendering interactivity and view instance tools #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded global script management
…e a view instance property to gain re-render persistence.
frreiss
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #202
Added interactivity to the JS-generated HTML rendering of SpanArrays and TokenSpanArrays, including table controls like visibility toggling and highlight locking.
Removed JupyterLab-specific CSS overrides in favor of more consistent styling across themes, and made some general styling adjustments.
Added highlights as a view instance property, preserving highlight locks over multiple view renders, but isolating the locks to the instance (Multiple JPL windows of the same notebook can have separate Spans hidden or highlighted at the same time).
Compatibility verified in JupyterLab and VSCode