Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple minor fixes to notebooks under tutorials directory #208

Merged
merged 13 commits into from
Jul 1, 2021

Conversation

frreiss
Copy link
Member

@frreiss frreiss commented Jun 15, 2021

This PR groups together a number of minor fixes to the notebooks and Python files under the tutorials directory. Summary of changes:

  • Fixed path issue that caused CoNLL_2.ipynb not to run
  • Added one more cell to CoNLL_2.ipynb to generate the example DataFrame used in the PyData Montreal talk.
  • Fixed a minor typo in a comment in Market_Intelligence_Part1.ipynb
  • Edited the Markdown text of Market_Intelligence_Part2.ipynb based on edits from the Medium blog version
  • Added the code-only notebooks, drawn directly from Market_Intelligence_Part1.ipynb, that were used in the PyData Montreal demo.
  • Removed unnecessary cells from one of the Github gist notebooks for Market_Intelligence_Part2.ipynb
  • Removed unused code from market_intelligence.py and synced some functions with their Github gist versions.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frreiss frreiss requested a review from BryanCutler June 15, 2021 21:09
@frreiss
Copy link
Member Author

frreiss commented Jun 23, 2021

@BryanCutler do you think you might have a chance to review these changes? I have some other changes queued up behind them.

@@ -250,7 +250,7 @@
"cell_type": "markdown",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this dependency parser description now, easier to understand


Reply via ReviewNB

@@ -0,0 +1,2455 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy() not necessary, reset_index will create a copy unless inplace=True


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll drop that from the next version of this file.

@@ -0,0 +1,336 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing about reset_index and copy


Reply via ReviewNB

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix this in the next commit.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just had a suggestion about a possible redundant copy() in the notebooks. I'll go ahead and merge this, and up to you if you want to revise that or not.

@BryanCutler BryanCutler merged commit 3aa3f65 into CODAIT:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants