Prep for second alpha release #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanCutler
approved these changes
Oct 15, 2020
| 1. Ensure that all the notebooks under the `notebooks` directory run and | ||
| produce substantially the same output as before. This step only needs to be | ||
| done with our primary versions of Python and Pandas at the time of the | ||
| release. |
There was a problem hiding this comment.
Is it possible to test this in CI?
There was a problem hiding this comment.
Looks like the best option is to convert notebook to a script with nbconvert package, then run the script. Maybe too much for CI, but we could make a bash script to run them all and launch it manually, wdyt? We should still run each notebook to check the output before release, but this might help to flush out any api changes..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increments the version number on master to
0.1a2and adds instructions for creating releases. Once this PR is merged, I'll test out those instructions with a second alpha release.