Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #140

Merged
merged 6 commits into from
Oct 14, 2020
Merged

Fix CI issues #140

merged 6 commits into from
Oct 14, 2020

Conversation

frreiss
Copy link
Member

@frreiss frreiss commented Oct 14, 2020

This PR should hopefully fix the issues we've been having with CI builds hanging.

I've added proper argument-handling code to env.sh, and I've fixed a bug that caused that script to hang if the PANDAS_VERSION environment variable is set.

env.sh now looks for an environment variable PYTHON_VERSION (there's also a command-line argument --python_version for non-Travis use) and installs the specified version of Python.

I've updated all the Travis builds to use the PYTHON_VERSION environment variable, and I've added an additional build for Python 3.8.

Copy link
Member

@BryanCutler BryanCutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BryanCutler BryanCutler merged commit e36e0af into CODAIT:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants