Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-545-Selenium-Tests-CertStore-Path-Mapping #951

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

JFU-GIT
Copy link
Contributor

@JFU-GIT JFU-GIT commented Jul 22, 2021

JIRA Ticket:
BB2-545

User Story or Bug Summary:

This is a follow up fix for BB2-545 :

The fhir client certstore path mapping does not work as expected on linux, causing tests fail (timeout) after grant access form submit, where an SSL cert path not found error occurred.

AC:

with the fix, selenium tests work as expected on linux.

What Does This PR Do?

Change the location where the fhir client certs (.pem files) are staged, to avoid docker volume mapping.

What Should Reviewers Watch For?

If you're reviewing this PR, please check these things, in particular:

  • TODO

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? No.
    • Does this PR modify or invalidate any of our security controls? No.
    • Does this PR store or transmit data that was not stored or transmitted before? No.
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? No.

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following pre-requisite changes have been fully deployed:

  • CMSgov/some_repo#42

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@JFU-GIT JFU-GIT added bug High High Priority For Reviewing labels Jul 22, 2021
@JFU-GIT
Copy link
Contributor Author

JFU-GIT commented Jul 22, 2021

also sync up with Pillow version bump in Dockerfile.selenium to avoid container build failure.

@nbragdon
Copy link
Contributor

@JFU-GIT Would you mind including a screenshot of this working on Linux?

@JFU-GIT
Copy link
Contributor Author

JFU-GIT commented Jul 26, 2021

@JFU-GIT Would you mind including a screenshot of this working on Linux?

ran on ubuntu in mslsx mode (not on vpn), and also WSL2 with ubuntu mslsx mode, running now to capture screen shot..., thanks for reviewing...

here are stdout captured on ubuntu:

34:Back to FHIR resource page:


** END TEST: auth_grant_w_no_demo, API: v2, STEP: 34, MSLSX


.

Ran 6 tests in 156.376s

OK
Destroying test database for alias 'default'...
run_selenium_tests_local_keybase.sh:
run_selenium_tests_local_keybase.sh: Stopping containers...
run_selenium_tests_local_keybase.sh:
Stopping bb2545verifyjul23fix_bb2slsx_1 ... done
Stopping bb2545verifyjul23fix_chrome_1 ... done
Stopping bb2545verifyjul23fix_msls_1 ... done
Stopping bb2545verifyjul23fix_db_1 ... done
Stopping selenium-hub ... done
run_selenium_tests_local_keybase.sh:
run_selenium_tests_local_keybase.sh: Shred and Remove certfiles from CERTSTORE_TEMPORARY_MOUNT_PATH=./docker-compose/certstore
run_selenium_tests_local_keybase.sh:
/usr/bin/shred
run_selenium_tests_local_keybase.sh: - Shredding files
run_selenium_tests_local_keybase.sh: - Removing files

screen shot:
image

Copy link
Contributor

@dtisza1 dtisza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JFU-GIT I believe this helped a little bit. I'm able to sometimes switch between mslsx and slsx type tests with them working. However, I'm still seeing the timeouts about 50% of the time.

I'm not wanting to hold things up, since this might be something only affecting me. I'll be able to run the tests locally when needed. Just wondering if there will be similar issues running under Linux via a Jenkins CBC job, but we should address that later if so.

Great work on this!

@JFU-GIT JFU-GIT merged commit 26dc9fe into master Jul 26, 2021
@JFU-GIT JFU-GIT deleted the jfuqian/BB2-545-Selenium-Tests-CertStore-Mapping branch July 26, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug High High Priority For Reviewing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants