-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Deps + Clean up Vendor File #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why all the hash changes seemingly without any change in expected version? Everything looks good and this for sure addresses the last error, but I'd be curious what went wrong for our convo on Monday.
--hash=sha256:6e6ff3db2d8dd0c986b4eec8554c8e4f919b5c1ff62a5b4390c17aff2ed6e5c4 \ | ||
--hash=sha256:ddc24a0a8280a0430baa37aff11f28574720af05888c62b7cfe71d219f4599d3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the big one I was looking for. This definitely resolves the error in the last build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks my build locally, working on summarizing the errors and identifying a fix to the Dockerfile to workaround it, but wanted to submit a review to make sure we don't deliver before then. Should have another comment in a few minutes!
I got an error on my docker-compose:
But adding
Of course adding
Hopefully we can just add this for now, but yea add that to the list of things we would ideally not have to do during dependency updates. |
@jimmyfagan That might be because that image might be ARM_X64 Vs AMD_X64 so the packages might be different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some edits to the Dockerfile and docker-compose.yml to get this to work for Mac, looking good now!
JIRA Ticket:
N/A
User Story or Bug Summary:
dependancy for prod build fail hash check
What Does This PR Do?
fixes hases and cleans up reqs versions
What Should Reviewers Watch For?
That this PR builds locally
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
What Needs to Be Merged and Deployed Before this PR?
N/A
Any Migrations?
Submitter Checklist
I have gone through and verified that...:
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.