Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Fix for 6 vulnerabilities + Dependency Management Fixes #1195

Merged
merged 10 commits into from
May 9, 2024

Conversation

sb-benohe
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • requirements/requirements.dev.txt
⚠️ Warning
django-oauth-toolkit 2.2.0 requires jwcrypto, which is not installed.

Vulnerabilities that will be fixed

By pinning:
Severity Priority Score (*) Issue Upgrade Breaking Change Exploit Maturity
low severity 44/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: High, Attack Vector: Network, EPSS: 0.00044, Social Trends: No, Days since published: 28, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Low, Package Popularity Score: 99, Impact: 2.35, Likelihood: 1.84, Score Version: V5
Uncontrolled Resource Consumption ('Resource Exhaustion')
SNYK-PYTHON-CRYPTOGRAPHY-6592767
cryptography:
42.0.4 -> 42.0.6
No No Known Exploit
high severity 124/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00081, Social Trends: No, Days since published: 90, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.06, Score Version: V5
Denial of Service (DoS)
SNYK-PYTHON-DJANGO-6230369
django:
4.2.7 -> 4.2.11
No No Known Exploit
medium severity 49/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00044, Social Trends: No, Days since published: 64, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 2.35, Likelihood: 2.06, Score Version: V5
Regular Expression Denial of Service (ReDoS)
SNYK-PYTHON-DJANGO-6370660
django:
4.2.7 -> 4.2.11
No No Known Exploit
medium severity 97/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Local, EPSS: 0.01055, Social Trends: No, Days since published: 25, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 5.99, Likelihood: 1.6, Score Version: V5
Resource Exhaustion
SNYK-PYTHON-IDNA-6597975
idna:
3.4 -> 3.7
No No Known Exploit
high severity 155/1000
Why? Confidentiality impact: Low, Integrity impact: Low, Availability impact: Low, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00045, Social Trends: No, Days since published: 36, Reachable: No, Transitive dependency: No, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.62, Likelihood: 2.74, Score Version: V5
Buffer Overflow
SNYK-PYTHON-PILLOW-6514866
pillow:
10.2.0 -> 10.3.0
No No Known Exploit
high severity 169/1000
Why? Confidentiality impact: None, Integrity impact: None, Availability impact: High, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.00045, Social Trends: No, Days since published: 21, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: High, Package Popularity Score: 99, Impact: 5.99, Likelihood: 2.81, Score Version: V5
Uncontrolled Recursion
SNYK-PYTHON-SQLPARSE-6615674
sqlparse:
0.4.4 -> 0.5.0
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Uncontrolled Resource Consumption ('Resource Exhaustion')

@sb-benohe sb-benohe self-assigned this May 7, 2024
@sb-benohe sb-benohe added enhancement dependencies Pull requests that update a dependency file labels May 7, 2024
@sb-benohe sb-benohe changed the title [Snyk] Fix for 6 vulnerabilities [Snyk] Fix for 6 vulnerabilities + Dependency Management Fixes May 7, 2024
Copy link
Contributor

@loganbertram loganbertram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We should simplify this process, but I know we're planning to go over it more at next eng sync.

Comment on lines -58 to -59
pip install selenium pytest Flask Flask-WTF
pip install cryptography==42.0.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably to enforce minimal installs at this stage, but the maintenance overhead of all these extra pinned versions and pip installs is probably too high.

@jimmyfagan
Copy link
Contributor

Our attempt to build an App AMI failed with ERROR: Could not find a version that satisfies the requirement django==4.2.11 (from versions: bootstrap-form-3.4, settings-export-1.2.1, 4.2.7)\nERROR: No matching distribution found for django==4.2.11, I think merging this should fix the issue, so going to go ahead and merge, cut a new release, and try again; hopefully that's okay.

@jimmyfagan jimmyfagan enabled auto-merge (squash) May 9, 2024 17:05
@jimmyfagan jimmyfagan merged commit f2feaaf into master May 9, 2024
6 checks passed
@jimmyfagan jimmyfagan deleted the snyk-fix-bd88405b3ffdca5d7fe992cd483287de branch May 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants