Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB2-1047] Bump Django to 2.2.26 Pillow to 8.3.3 to mediate vuln (DoS) #1005

Merged

Conversation

JFU-GIT
Copy link
Contributor

@JFU-GIT JFU-GIT commented Jan 5, 2022

JIRA Ticket:
BB2-1047

User Story or Bug Summary:

Summary:

Per Snyk scan:

Detected vulnerabilities of Medium level in following:
M Denial of Service (DoS)
Vulnerability in pillow 8.3.2.

M Denial of Service (DoS)
Vulnerability in django 2.2.25.

L Information Exposure
Vulnerability in django 2.2.25.

Details:

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45115

AC:

Upgrade Django and Pillow to the versions per mediate instruction.

What Does This PR Do?

What Should Reviewers Watch For?

If you're reviewing this PR, please check these things, in particular:

  • TODO

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? No.
    • Does this PR modify or invalidate any of our security controls? No.
    • Does this PR store or transmit data that was not stored or transmitted before? No.
  • If the answer to any of the questions below is Yes, then please add StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? No.

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following pre-requisite changes have been fully deployed:

  • CMSgov/some_repo#42

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime, etc)
  • No migrations

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

Copy link
Contributor

@dtisza1 dtisza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! TY for updating these packages!

@njdister
Copy link
Contributor

njdister commented Jan 5, 2022

The PR mentions Pillow 8.3.3 but the code bumps it to 9.0. Have the logo uploading features been tested for regressions? If all is good, can you update the PR title?

@JFU-GIT
Copy link
Contributor Author

JFU-GIT commented Jan 6, 2022

The PR mentions Pillow 8.3.3 but the code bumps it to 9.0. Have the logo uploading features been tested for regressions? If all is good, can you update the PR title?

Yea, when branching used the pillow833, but think it'd be OK since it is bumped to pillow 9.0.0

@JFU-GIT JFU-GIT merged commit bc028f5 into master Jan 6, 2022
@JFU-GIT JFU-GIT deleted the jfuqian/BB2-1047-Bump-Django-to-2.2.26-Pillow-to-8.3.3 branch January 6, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants