Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics using arviz to tutorials #219

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jun 27, 2024

Two changes made:

  • added mcmc diagnostics to the two tutorials
  • changed num_chains=2 from deafult value of 1. This was required to suppress a warning about convergence diagnostics

@sbidari sbidari linked an issue Jun 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (84f7809) to head (3e8cb63).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   92.47%   92.47%           
=======================================
  Files          40       40           
  Lines         877      877           
=======================================
  Hits          811      811           
  Misses         66       66           
Flag Coverage Δ
unittests 92.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor code style things, otherwise LGTM

model/docs/example_with_datasets.qmd Outdated Show resolved Hide resolved
model/docs/example_with_datasets.qmd Outdated Show resolved Hide resolved
model/docs/getting_started.qmd Outdated Show resolved Hide resolved
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dylanhmorris dylanhmorris merged commit 5748007 into main Jun 27, 2024
8 checks passed
@dylanhmorris dylanhmorris deleted the add-diagnostics-using-arviz-to-tutorials branch June 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add diagnostics using Arviz to tutorials
3 participants