Redesign Specs #154

chemistry-sourabh · 2017-11-07T00:41:22Z

First Draft of BMI Redesign specs

nasibehteimouri · 2017-11-07T12:52:27Z

All is matched with what I learnt from you guys and the discussions. Great job!

knikolla · 2017-11-29T03:51:52Z

There goes my quiet evening!

knikolla

I did not go through the entire thing, but I have really serious concerns about the way you think you can handle authentication. Come talk to me.

knikolla · 2017-11-29T03:55:06Z

docs/redesign-specs/DB_Schema/database.md

+2. An access control list (ACL) can be created by any user (a.k.a. the user creating the access control list will be its owner). 
+3. Owner of an access control list can add/remove user from the access control list. 
+4. Owner can transfer the ownership of the access control list to another user. 
+5. Owner can share an access control list with another user. 


Define: share. And how is it different from adding a user to the ACL.

knikolla · 2017-11-29T04:02:48Z

docs/redesign-specs/DB_Schema/database.md

+* isSnapshot : This flag is `true` in case of snapshot and not an uploaded image
+* dataStoreId : Id of the DataStore that gives information about where this image is stored. 
+
+**NOTE:** `(name, ownerUserId) pair is unique key.`


If you have an image named openstack-compute and I try to give you ownership of my own openstack-compute, that wouldn't work because it hits this constraint. User would have to rename an image.

knikolla · 2017-11-29T04:06:08Z

docs/redesign-specs/DB_Schema/database.md

+3.  All tag must be deleted before de-provisioning. 
+
+* id : Id of the tag (primary key)
+* name : Name of the tag


I don't really think you need ID here. A unique name would be enough, and make the pair (name, nodeId) unique.

knikolla · 2017-11-29T04:07:54Z

docs/redesign-specs/DB_Schema/database.md

+2. DataStore: A filesystem service where images are stored.
+3. ProvisionEngine: A service used to (de)-provision a node.
+
+* The three above tables have `<id>` (primary key), `<name>` (unique key), `<type>`, `<url>` (unique key), `<ip>`, and `<port>`


I strongly disagree with this abstraction. If you think you can make an authentication driver work with that much information, we need to talk. Also why have ip, port and also url. I would just keep url, since that will include also the protocol of communication, which you are missing here.

knikolla · 2017-11-29T04:10:06Z

docs/redesign-specs/DB_Schema/database.md

+
+***
+
+## Vlan 


A driver which supports multiple technologies will not work if you settle on only VLANs.

BMI assumes that the underlying network isolation layer (e.g. HIL) is layer-2 based.

We should be supporting IB next year as well, in which case IP address doesn't work ... Also eventually omnipath... Agree with L2. Having said that, I don't think its unreasonable that BMI talk to the management network, typically that is just ethernet, i.e., BMI doesn't care about the data networks. For this release, lets call it network, not VLAN, but we can probably only be concerned with VLANs?

knikolla · 2017-11-29T04:15:15Z

docs/redesign-specs/REST/Api.md

+**NOTE**: After the example, an explanation for each parameter must be provided.
+
+The response header will contain the HTTP status code:
+* 200 for success


In the cases of success but no body returned in the response, please use 204.

knikolla · 2017-11-29T04:19:20Z

docs/redesign-specs/REST/Api.md

+
+Register a data store.
+
+`POST /dataStores`


Please remove the camelCasing. datastores

knikolla · 2017-11-29T04:20:44Z

docs/redesign-specs/REST/Api.md

+**NOTE**: `Response Body Example (Failure)` is not required for every API call
+
+#### Authentication (Optional):
+* If Authentication is required by REST API call then the Credentials/Token should be passed using `HTTP Basic Auth`.


Different authentication methods have different ways to pass credentials. Please, please, do not do this. Use a middleware (like keystonemiddleware) or apache module for this.

okrieg · 2017-12-05T18:52:15Z

docs/redesign-specs/DB_Schema/database.md

+* id : Id of the user (primary key)
+* name : Name of the user (unique key) 
+* type : Type of user (ordinary user or admin)
+* quota : Quantity of datastore disk-space allocated to a user (GB)


Is this for the disk space? I am confused by figure, where the datastore/storage provider is coupled with the database. I think that storage provider should be closely associated with the iscsi service. You really want a single driver for communicating with storage to clone volumes... and to set up ISCSI end points for those volumes. For quota, is this the absolute size of the volumes, or is this the new storage incurred due to the clone; in many case the latter will be orders of magnitude less

okrieg · 2017-12-05T18:53:42Z

docs/redesign-specs/DB_Schema/database.md

+* name : Name of the user (unique key) 
+* type : Type of user (ordinary user or admin)
+* quota : Quantity of datastore disk-space allocated to a user (GB)
+* status : Current status of user (e.g. active, inactive, disabled, etc.)


What does this mean? How can you tell if someone is active? If you have any machines currently backed by BMI then it is active, so user stays active for days/weeks/months? What is purpose of this?

okrieg · 2017-12-05T18:54:45Z

docs/redesign-specs/DB_Schema/database.md

+* type : Type of user (ordinary user or admin)
+* quota : Quantity of datastore disk-space allocated to a user (GB)
+* status : Current status of user (e.g. active, inactive, disabled, etc.)
+* autheticationId : Id of the authentication service using which a user will be verified in a multi-tenant setup. A user will specify a token (obtained from the authentication service) while invoking the REST API.


Don't know enough, but that doesn't seem right to me...

okrieg · 2017-12-05T18:56:14Z

docs/redesign-specs/DB_Schema/database.md

+4. Snapshot is a special type of image that is created by deep copying the existing state of a provisioned node's image. 
+5. Image/Snapshot owner can be different from the owner of an ACL. 
+6. Ownership of the image/snapshot can be transfered to another user.
+7. Image/Snapshot can be shared to a set of users.


if shared, and used, can the "owner" delete it? If public, who owns it?

okrieg · 2017-12-05T18:57:35Z

docs/redesign-specs/DB_Schema/database.md

+5. BMI creates an interface (physical or virtual) on the provisioning engine for the users' provisioning network.
+
+* id : Id of the provisioned node (primary key)
+* macAddress : Mac address of the provisioned node (unique key)


I would rather use terms like networkAddress, and say, e.g., macAddress, some day we will move away from ethernet

okrieg · 2017-12-05T18:58:27Z

docs/redesign-specs/DB_Schema/database.md

+* cloneName :  Name of the cloned image (unique key)
+* nic : NIC of the provisioned node 
+* ownerUserId : Id of the user who owns the provisioned node 
+* provisionEngineVlanId: Id of the provisionEngineVlan. This column represents the `(provisioning engine, vlan interface)` pair that is used to provision the given node.


can we call network, and say, for example Vlan... some day move away from Vlans...

okrieg · 2017-12-05T19:00:45Z

docs/redesign-specs/redesignrequirements.md

+  - Support for different authentication services (e.g. LDAP, Kerberos, etc.).
+  - Support for different data stores (e.g. Lustre, etc).
+  - Support for different network isolators.
+


I don't see the mechanisms you are using... do we have a plugin architecture? How configure...

chemistry-sourabh added 2 commits November 6, 2017 19:32

Initial Commit

2ac0ca4

Replaced with png image

c0b6e0b

chemistry-sourabh assigned apoorvemohan, chemistry-sourabh and nasibehteimouri Nov 7, 2017

chemistry-sourabh added 4 commits November 10, 2017 16:02

requirements

5bd2ee2

Updated Schema

0732164

Pushed DB Doc

a38c257

Updated flatten-tag

6d18d33

knikolla suggested changes Nov 29, 2017

View reviewed changes

okrieg reviewed Dec 5, 2017

View reviewed changes

apoorvemohan added 11 commits December 19, 2017 13:11

ACL, Auth, DS, VLAN, Prov engine API removed

daf07c4

background and bmi core resources

41d46a9

Provisioned Instance

19ba844

Quota

cd335bd

image and snapshot

aed16fe

list operations

4de4262

minor edits

2f763e2

bmi-usecase-slides

2164570

Delete BMI Architecture Idea.png

3b27a16

Update BMI Redesign Idea

c1d33a4

latest bmi db schema

c107da2

apoorvemohan and others added 5 commits January 11, 2018 13:04

removing old schema

7387c4e

removing old db schema description

83c39e8

Delete bmi-usecase-slides.pdf

764ac35

Add files via upload

c3cc932

database description is committed!

48fc749

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign Specs #154

Redesign Specs #154

chemistry-sourabh commented Nov 7, 2017

nasibehteimouri commented Nov 7, 2017

knikolla commented Nov 29, 2017

knikolla left a comment •

edited

Loading

knikolla Nov 29, 2017

knikolla Nov 29, 2017

knikolla Nov 29, 2017

knikolla Nov 29, 2017

knikolla Nov 29, 2017

apoorvemohan Nov 29, 2017

okrieg Dec 5, 2017 •

edited

Loading

knikolla Nov 29, 2017

knikolla Nov 29, 2017

knikolla Nov 29, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017

okrieg Dec 5, 2017


		***

		## Vlan

Redesign Specs #154

Are you sure you want to change the base?

Redesign Specs #154

Conversation

chemistry-sourabh commented Nov 7, 2017

nasibehteimouri commented Nov 7, 2017

knikolla commented Nov 29, 2017

knikolla left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okrieg Dec 5, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

knikolla left a comment •

edited

Loading

okrieg Dec 5, 2017 •

edited

Loading