[pull] main from sourcegraph:main #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename batches-specific webhooks for clarity * PR comments
The redigo/redis version we use now was published in 2018, and has since been retracted - the latest versions are still being published on 1.x, with the latest release v1.8.9 being published this year: https://pkg.go.dev/github.com/gomodule/[email protected]/redis?tab=versions This upgrades our dependency to use this latest version, and also removes an unused rcache mutex functionality from package rcache that no longer works with this new version of redigo.
Co-authored-by: keegancsmith <[email protected]>
… the Mozilla store (#44380)
To ensure that a previous test didn't cause the repo to already exist on disk.
I noticed that the logger param wasn't being used in New. We now create an observation context using the supplied logger. Also deleted some dead code and fixed a typo.
We export two specific metrics for hybrid search and add a hidden group showing the metrics. We included a detailed interpretation of the results aswell as emphasize the experimental nature of the feature. The plan is once the feature is turned on by default it won't be hidden by default. Test Plan: ran the local monitoring stack, but connected to prod. Also will check the output of markdown in the github renderer.
* [dotcom] Add validation to subscription path param Fixes #39837 * Fix snapshot unit test
This commit increases the test coverage for hybrid to all major conditionals. It also fixes a minor bug around path and content search. Test Plan: go test
We have hardcoded this value to true in the client for a very long time. This PR removes the field and updates conditionals as if the field was true. Additionally test cases based on glob fields are updated to pass in the equivalent regex. A follow-up PR will remove glob support from our path matcher package. Test Plan: go test
PRs landed concurrently that introduced these uses as well as a PR that removed them. Test Plan: go test ./cmd/searcher/...
web: add SiteAdminWebhookPage component. Test plan: Storybook and local sg visual checks.
Removed some dead code and simplified the signature of a method. Just a few small things I spotted while thinking about how we can simply webhook setup.
We need to ensure that `git p4` commands can write to $HOME as they need to write cache data so we pass it a folder under our default data directory.
We only ever use the regex functionality, so update the package to only support regex inputs. Test Plan: go test
* Extend legend list UI API * Bring aria state and labels to the legend list insight card * Adjust line chart axis tick (space per tick) prop * Use li > legend item control combination instead of role mix * Adjust component UI separation in legend item list * Fix default padding value (help with initial chart paint)
* Fix PieChart keyboard navigation * Fix PieChart styles (code style)
Added some test cases for `ignorePath`
Due to the large index on .com, it happens quite frequently that ranked content matches are relegated to below the fold by repo results. This PR builds on similar, existing logic for searcher jobs and ensures we execute repo searches last.
Noticed that the SQL snippet had a missing comma while copy & pasting it.
Co-authored-by: Jean-Hadrien Chabran <[email protected]> Co-authored-by: Philipp Spiess <[email protected]> Co-authored-by: Taras Yemets <[email protected]>
…avigation (#44780) Fix scroll into view for the dashboard grid keyboard navigation
* Add lang stats insight preview hook * Remove legacy built-in (runtime) and lang stats preview backend service methods * Migrate dashboard lang stats card UI * Migrate lang stats live preview card * Migrate lang stats standalone insight UI * Fix lang stats storybook preview * Fix integration test mock setup * Fix code style * Split sync and lazy lang stats insight preview logic
See sourcegraph/go-diff@f8cd299 for more details, tl;dr this fixes empty added and deleted files on Sourcegraph rendering incorrectly in the diff view (was completely broken before)
* Add tail element to the chart tooltip UI * Run prettier * Add sticky tooltip position logic to the line chart * Add sticky position logic to the bar chart * Fix svg interactive area problem for the line chart * Turn off focus ring for the root svg element
This was a concept we had in Cloud V1 which we no longer support.
If a user e-mail is removed. This change also adds more options to the `Delete` method on the `UserExternalAccountsStore`
* Remove Cloud V1 related PermStore functions
No longer high cardinality on dotcom. Let's remove it.
* build-tracker: better handling of large job failures * Update dev/build-tracker/slack_test.go
This PR improves how we handle failed to apply patch errors by doing the following: - Make it a 4xx error so that we don't retry this request through the internalClient - Make a patch does not apply a fatal error so that the dbworker doesn't retry it - Actually return the well formatted CreateCommitFromPatch from the client
Move sg's docgen code into lib/cliutil/docgen for sharing with the mi CLI. In the future we can move other useful utilities for urfave/cli and CLIs in general into this set of subpackages for use in mi.
This printed as 1false instead of 1.
This is a clarification on a common error running the drift command - it also makes the version tag in another example under upgrade consistent
When looking at dashboards we have a few errors across our different places we can fail. However, in everycase the logs seem to correlate with request cancellation (as well as a high volume of requests). As such we ensure we always handle these conditions when recording metrics. Test Plan: go test as well as monitoring grafana in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )