Automatically escape fields that contain the comment character #283
Conversation
Currently, if data is written with QuoteStyle::Necessary, and the first field of a row happens to contain a comment character, the row will be ignored as a comment when later reading it back in. This change adds a `comment` property to Writer, and automatically quotes fields that have the provided comment character in them, so they round-trip correctly.
|
@BurntSushi Gentle ping - I know you're busy. Any thoughts on if this is something you would be interested in including? |
There was a problem hiding this comment.
This makes sense as when using the Reader interface with a comment character you'd loose lines that start with the comment if it's not escaped.
I'm not sure API-wise if it's better to have uniformity with the reader here and re-use comment, or just straight up allow setting characters to the requires_quotes array directly (as we're not writing comments!), but that's a matter of taste for @BurntSushi to decide and something that has less overhead than QuoteStyle::Always definitely looks sane to me.
It'd be great if you could spare a minute to give some feedback and/or merge this :)
|
Is the latest commit what you had in mind? |
Previously, if data is written with QuoteStyle::Necessary, and the first field of a row happens to contain a comment character, the row will be ignored as a comment when later reading it back in. This change adds a `comment` property to Writer, and automatically quotes fields that have the provided comment character in them, so they round-trip correctly. Closes #283
Previously, if data is written with QuoteStyle::Necessary, and the first field of a row happens to contain a comment character, the row will be ignored as a comment when later reading it back in. This change adds a `comment` property to Writer, and automatically quotes fields that have the provided comment character in them, so they round-trip correctly. Closes #283
|
This PR is in |
|
Thank you very much! |
Currently, if data is written with QuoteStyle::Necessary, and the first
field of a row happens to start with a comment character, the row will be
ignored as a comment when later reading it back in.
This change adds a
commentproperty to Writer, and automaticallyquotes fields that have the provided comment character in them, so they
round-trip correctly.