Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: A note about internally-tagged enums not supported #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeenix
Copy link

@zeenix zeenix commented May 3, 2021

Internally-tagged enums are extremely useful and therefore used quite a lot in the wild. It's a bit of a shock to users to learn (the hard way) that they're not supported by csv. So it'd be great to at least document this limitation in the docs.

Internally-tagged enums are extremely useful and therefore used quite a
lot in the wild. It's a bit of a shock to users to learn (the hard way)
that they're not supported by `csv`. So it'd be great to at least
document this limitation in the docs.
@zeenix
Copy link
Author

zeenix commented Jun 3, 2023

@BurntSushi could you please have a look?

@zeenix
Copy link
Author

zeenix commented Sep 3, 2023

@BurntSushi Given that you explicitly asked me for this PR and it's a simple change that will likely help a lot of people avoid bumping into the serious and unexpected limitation, ignoring it for years, is very disrespectful to say the least. 😔

@wiktor-k
Copy link

I just found this ticket after trying to get internally tagged enums to work... it'd be really nice if this was merged to at least warn users about the limitations 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants