Do not convert to string when skipping unused fields. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the deserializer skips unused fields, we don't have to convert them to valid Utf-8 string. This will prevent errors when unused fields are not Utf-8 (maybe they are supposed to be bytes). Removing the check may also improve performance.
|
Hi @BurntSushi, Could you please look into this PR? It sems like a reasonable change, skipped fields be validated as UTF-8? As I understand it, if you use |
|
This PR is on crates.io in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. This is reopening of #198, but with just one of the two commits. Turns out that this is still needed for the suggested solution to work.
If some fields are not required by serde, the
ByteRecord::deserializewill attempt to skip them by callingnext_field, which will fail if the skipped field is not valid utf-8. So instead lets skip unused fields usingnext_field_bytes. This affects alsoStringRecord::deserialize, but getting byte slice from string should have no cost. I didn't see any changes in the included benchmarks.