csv: fix equality check for raw records

This commit fixes the equality check for the StringRecord and
ByteRecord types such that the field boundaries are respected.
That is, [123, 4] should not be equal to [1, 234], but these
previously were treated as equivalent.

Fixes #138

src/byte_record.rs

@@ -109,7 +109,7 @@ pub struct ByteRecord(Box<ByteRecordInner>);
 
 impl PartialEq for ByteRecord {
  fn eq(&self, other: &ByteRecord) -> bool {
- self.as_slice() == other.as_slice()
+ self.iter().zip(other.iter()).all(|e| e.0 == e.1)
  }
 }
 

src/string_record.rs

@@ -74,7 +74,7 @@ pub struct StringRecord(ByteRecord);
 
 impl PartialEq for StringRecord {
  fn eq(&self, other: &StringRecord) -> bool {
- self.as_slice() == other.as_slice()
+ self.iter().zip(other.iter()).all(|e| e.0 == e.1)
  }
 }
 

tests/tests.rs

@@ -1,5 +1,10 @@
 #![allow(dead_code)]
 
+extern crate csv;
+
+use csv::ByteRecord;
+use csv::StringRecord;
+
 use std::env;
 use std::io::{self, Write};
 use std::path::PathBuf;
@@ -333,6 +338,24 @@ fn tutorial_perf_core_01() {
  assert_eq!(out.stdout(), "11\n");
 }
 
+///Check for correctness of ```impl PartialEq for ByteRecord``` (Issue #138)
+#[test]
+fn byte_record_eq_field_boundaries() {
+ let test1 = ByteRecord::from(vec!["12","34"]);
+ let test2 = ByteRecord::from(vec!["123","4"]);
+
+ assert_ne!(test1, test2);
+}
+
+///Check for correctness of ```impl PartialEq for StringRecord``` (Issue #138)
+#[test]
+fn string_record_eq_field_boundaries() {
+ let test1 = StringRecord::from(vec!["12","34"]);
+ let test2 = StringRecord::from(vec!["123","4"]);
+
+ assert_ne!(test1, test2);
+}
+
 // Helper functions follow.
 
 /// Return the target/debug directory path.