[ignore] Fix matched_path_or_any_parents() for patterns ending in slash #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `matched_path_or_any_parents()` implementation, we missed the point that when we start walking up the tree, we have to set `is_dir` to `true`, so path `ROOT/a/b/c` matches pattern `/a/`, although the original path is not a dir.
|
I didn't test this diff locally (because I did this on a different machine than the Cargo patch) and the bug was revealed in my tests for the cargo patch. Fortunately, it doesn't involve API breaking changes. Sorry for making more release work for you, @BurntSushi, and thanks in advance. :) |
|
Nice find! If you do need to make a breaking API change, then I expect we could get away with a yank. :) I'll cut a release when I'm at my computer next. |
|
Just a friendly reminder to publish |
|
Ah right, I was on vacation and forgot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
matched_path_or_any_parents()implementation, we missed the pointthat when we start walking up the tree, we have to set
is_dirtotrue, so pathROOT/a/b/cmatches pattern/a/, although theoriginal path is not a dir.