Add ARM build configurations to CI and release workflows #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please ignore the other 2. I was trying to push another commit in a separate branch, but it ended up (twice) in the master branch and it was included in the PR. I had to close them and submit this one instead. |
|
Hmm okay. Just so you're aware, you can rebase and force push. |
|
How did you test this? You have to run the release workflow and ensure the binaries are produced in a fork. Right now, it fails because the Ah okay... It looks like the Cross project changed this around. Sigh. It's now here: |
... it turns out that rustembedded/cross:armv7-unknown-linux-musleabi doesn't exist. And looking more closely, it looks like the Cross project has decided to shake things up and publish images to ghcr instead. So we migrate everything over to that.
It looks like these aren't needed any more? I'm not sure why to be honest. I suspect it's because we no longer need asciidoc(tor)? to generate man pages. And I believe tests that require things like `zstd` are automatically if `zstd` isn't installed.
|
Switching everything over to ghcr.io was a bit of a pain. It also turned out that we don't need the old custom images I was maintaining any more. But that was probably true before. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 8, 2024
14.1.0 ====== This is a minor release with a few small new features and bug fixes. This release contains a bug fix for unbounded memory growth while walking a directory tree. This release also includes improvements to the completions for the `fish` shell, and release binaries for several additional ARM targets. Bug fixes: * [BUG #2664](BurntSushi/ripgrep#2690): Fix unbounded memory growth in the `ignore` crate. Feature enhancements: * Added or improved file type filtering for Lean and Meson. * [FEATURE #2684](BurntSushi/ripgrep#2684): Improve completions for the `fish` shell. * [FEATURE #2702](BurntSushi/ripgrep#2702): Add release binaries for `armv7-unknown-linux-gnueabihf`, `armv7-unknown-linux-musleabihf` and `armv7-unknown-linux-musleabi`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following targets: