Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support curly brace glob syntax #80

Closed
SevereOverfl0w opened this issue Sep 25, 2016 · 2 comments
Closed

Support curly brace glob syntax #80

SevereOverfl0w opened this issue Sep 25, 2016 · 2 comments
Labels
enhancement An enhancement to the functionality of the software.

Comments

@SevereOverfl0w
Copy link

Supporting globbing like {a,b} would be extremely useful for "or" based usage: *.min.{css,js}, I imagine this would also be significantly more performant, particularly when using 7/8 separate globs instead of one big or glob.
@BurntSushi
Copy link
Owner

It actually won't be more performant. Globs are already compiled down to a single finite state machine.

In any case, yes, we should support this syntax.

@SigmundVik SigmundVik mentioned this issue Sep 25, 2016
Closed
@BurntSushi BurntSushi added the enhancement An enhancement to the functionality of the software. label Sep 25, 2016
@BurntSushi
Copy link
Owner

This was fun. All done!

amsharma91 added a commit to amsharma91/ripgrep that referenced this issue Sep 27, 2016
@amsharma91
Add curly brace alternates to glob format.
1460646 
Closes BurntSushi#80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement to the functionality of the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @SevereOverfl0w