Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

termcolor does not support underlining text #798

Closed
gnzlbg opened this issue Feb 13, 2018 · 5 comments
Closed

termcolor does not support underlining text #798

gnzlbg opened this issue Feb 13, 2018 · 5 comments
Labels
enhancement An enhancement to the functionality of the software. help wanted Others are encouraged to work on this issue.

Comments

@gnzlbg
Copy link

gnzlbg commented Feb 13, 2018

What version of ripgrep are you using?

Does not apply.

Describe your question, feature request, or bug.

termcolor does not support underlining text. Would be great if it could.
@BurntSushi BurntSushi added enhancement An enhancement to the functionality of the software. help wanted Others are encouraged to work on this issue. labels Feb 14, 2018
@BurntSushi
Copy link
Owner

This seems like a simple enough addition. If anyone wants to work on this, it should be relatively easy: just do what bold does, but implement underlining.

@PramodBisht
Copy link

@BurntSushi I am picking this one.

@okdana
Copy link
Contributor

okdana commented Feb 18, 2018

@PramodBisht if you mean you intend to work on this, PR #805 has already been submitted

@gnzlbg
Copy link
Author

gnzlbg commented Feb 18, 2018

@okdana thanks! that looks nice!

FWIW this is why PRs that close issues should reference the issues either in the PR or the commit messages :D

@PramodBisht
Copy link

PramodBisht commented Feb 18, 2018 •
edited
Loading

@gnzlbg @okdana Great! my work was almost done :‑(

@balajisivaraman balajisivaraman mentioned this issue Feb 19, 2018
Merged
BurntSushi pushed a commit that referenced this issue Feb 20, 2018
@balajisivaraman @BurntSushi
termcolor: add underline support
d57fc58 
This commit adds underline support to the termcolor crate, and
exposes it through ripgrep.

Fixes #798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement to the functionality of the software. help wanted Others are encouraged to work on this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@okdana @BurntSushi @gnzlbg @PramodBisht