Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version string is malformed when using cargo install #789

Closed
BurntSushi opened this issue Feb 12, 2018 · 1 comment
Closed

version string is malformed when using cargo install #789

BurntSushi opened this issue Feb 12, 2018 · 1 comment
Labels
bug A bug.

Comments

@BurntSushi
Copy link
Owner

When running cargo install ripgrep, the git hash in the version string is improperly formatted. In this case, we should just omit the revision identifier altogether.

Example:

ripgrep 0.8.0 (rev )

We should probably improve how we use git to get the hash. e.g., What happens if you compile ripgrep from its git source, but outside the git repo itself?
@BurntSushi BurntSushi added the bug A bug. label Feb 12, 2018
@BurntSushi BurntSushi mentioned this issue Feb 12, 2018
Merged
@okdana
Copy link
Contributor

okdana commented Feb 12, 2018

FYI, the official Homebrew version of rg has this problem too, presumably because they build from the source tarball. I agree that just omitting the revision when it's not available would be nicer / less confusing.

BurntSushi added a commit that referenced this issue Feb 21, 2018
@BurntSushi
doc: omit revision when it isn't available
03c95bf 
If the revision is empty, then we shouldn't show the `(rev )` text in
the output of `rg --version`.

Fixes #789
@BurntSushi BurntSushi mentioned this issue Feb 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okdana @BurntSushi