Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerated usage mismatches binary name #426

Closed
kpp opened this issue Mar 30, 2017 · 7 comments
Closed

Autogenerated usage mismatches binary name #426

kpp opened this issue Mar 30, 2017 · 7 comments

Comments

@kpp
Copy link
Sponsor Contributor

kpp commented Mar 30, 2017 

$ rg -h | head -n14 | tail -n 1
USAGE:ripgrep [OPTIONS] <pattern> [--] [path]...

It should be USAGE:rg [OPTIONS] <pattern> [--] [path]...
kpp added a commit to kpp/ripgrep that referenced this issue Mar 30, 2017
@kpp
Apply binary name to clap
6b5ced6 
Fixes BurntSushi#426
@kpp kpp mentioned this issue Mar 30, 2017
Closed
@BurntSushi
Copy link
Owner

This is a dupe of #418 I think. That is, I think it's the same underlying regression.

I think this was supposed to be fixed in the latest version of clap, but it's not.

@BurntSushi BurntSushi mentioned this issue Mar 30, 2017
Closed
@kbknapp
Copy link
Contributor

kbknapp commented Mar 30, 2017

Looking at it now ;-)

@kbknapp
Copy link
Contributor

kbknapp commented Mar 30, 2017

I found the issue.

@kbknapp kbknapp mentioned this issue Mar 30, 2017
Merged
@kpp
Copy link
Sponsor Contributor Author

kpp commented Mar 30, 2017

Ah, I see. Thank you!

homu added a commit to clap-rs/clap that referenced this issue Mar 30, 2017
@homu
Auto merge of #921 - kbknapp:template-fix, r=kbknapp
080a9d8 
Template fix

Fixes BurntSushi/ripgrep#426 and BurntSushi/ripgrep#418

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/kbknapp/clap-rs/921)
<!-- Reviewable:end -->
@BurntSushi
Copy link
Owner

@kbknapp Wow! I'm surprised Github closed this issue from your PR. (I'm reopening it because it doesn't actually get fixed until deps are bumped... Hah.)

@BurntSushi BurntSushi reopened this Mar 30, 2017
@BurntSushi
Copy link
Owner

Probably because I once tried to set up @homu on this repo, and so it has access. Cool.

@kbknapp
Copy link
Contributor

kbknapp commented Mar 30, 2017 •
edited
Loading

Wow I had no idea that would happen, I apologize! I'd almost call that a bug, since I shouldn't be allowed to close your PRs and Issues 😜

@kpp kpp mentioned this issue Mar 30, 2017
Merged
@kbknapp kbknapp mentioned this issue Mar 31, 2017
Open
kpp added a commit to kpp/ripgrep that referenced this issue Mar 31, 2017
@kpp
Bamp clap to 2.22.2
2514c13 
Fixes BurntSushi#426 , BurntSushi#418
BurntSushi pushed a commit that referenced this issue Mar 31, 2017
@kpp @BurntSushi
Bamp clap to 2.22.2
1425d67 
Fixes #426 , #418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BurntSushi @kpp @kbknapp