Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate .rgingore, switch to .ignore #40

Closed
BurntSushi opened this issue Sep 24, 2016 · 11 comments
Closed

deprecate .rgingore, switch to .ignore #40

BurntSushi opened this issue Sep 24, 2016 · 11 comments
Labels
enhancement An enhancement to the functionality of the software.

Comments

@BurntSushi
Copy link
Owner

As discussed between myself and @ggreer: https://news.ycombinator.com/item?id=12568822 Yay cooperation!

@BurntSushi BurntSushi added the enhancement An enhancement to the functionality of the software. label Sep 24, 2016
BurntSushi added a commit that referenced this issue Sep 24, 2016
But don't actually remove support for .rgignore until the next semver
bump.

Note that this puts us in line with the silver searcher:
ggreer/the_silver_searcher#974

Fixes #40
@tinyapps
Copy link

Might it also be possible to add a switch like ag's --ignore PATTERN?

Ignore files/directories whose names match this pattern. Literal file and directory names are also allowed.

Sorry - don't mean to hijack this thread; just seemed tangentially related.

@BurntSushi
Copy link
Owner Author

rg has it with the -g/--glob flag.

@tinyapps
Copy link

Thanks for the fast response! And sorry for bothering you - I had tried the --glob flag, but had been erroneously placing it before the search term with the other options. After reading your response here, found your detailed blog post with a slew of examples, including just the one I was after:

exclude files matching a particular glob:

$ rg foo -g '!*.min.js'

@BurntSushi
Copy link
Owner Author

Strange, the placement of -g (before or after pattern) shouldn't have any effect.

@tinyapps
Copy link

I must apologize again: on closer inspection, the problem was me not enclosing the glob in single quotes. I was doing this sort of thing:

$ rg -t html -g index* searchterm
No such file or directory (os error 2)

@BurntSushi
Copy link
Owner Author

Ah, yup, that'll do it. The shell takes over there. No worries! Glad you got it straightened out. :-)

@tinyapps
Copy link

tinyapps commented Sep 24, 2016

Thanks again for the super-fast replies Andrew! And of course, for crafting ripgrep - it is a marvel! Do you accept donations? Or have an Amazon wish list or the like?

@BurntSushi
Copy link
Owner Author

BurntSushi commented Sep 24, 2016

@tinyapps Thanks! You're very kind. :-) If you're so inclined, please donate it to a cause you find worthy. (I'd recommend Wikipedia.)

@tinyapps
Copy link

Done! $100 sent to Wikipedia a few moments ago thanks to you and your generosity!

@BurntSushi
Copy link
Owner Author

Wow. That's very generous of you! Thank you so much! :-)

@tinyapps
Copy link

No, it is you who is so generous with your time and expertise! And that after having been on the HN front page all day! Cannot thank you enough!

amsharma91 added a commit to amsharma91/ripgrep that referenced this issue Sep 27, 2016
But don't actually remove support for .rgignore until the next semver
bump.

Note that this puts us in line with the silver searcher:
ggreer/the_silver_searcher#974

Fixes BurntSushi#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to the functionality of the software.
Projects
None yet
Development

No branches or pull requests

2 participants