-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set globs have incorrect behavior #391
Labels
Comments
Yup, the bug is here: Lines 657 to 665 in cf750a1
All it needs is a regression test and some parens pushed around the alternation. |
tiehuis
added a commit
to tiehuis/ripgrep
that referenced
this issue
Mar 4, 2017
BurntSushi
pushed a commit
that referenced
this issue
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Repro:
The output includes files in the
.git
directory. Interestingly, removing some of the extensions in the second--glob
impacts the output in unexpected ways. Changing the first glob to not use a recursive glob also seems to make it work.If I look at the debug output, it looks like the generated regex for the second glob is:
Which is just plain wrong. The alternation should be in a group.
The text was updated successfully, but these errors were encountered: