Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--hidden doesn't work with --type all #1344

Closed
kurnevsky opened this issue Aug 7, 2019 · 9 comments
Closed

--hidden doesn't work with --type all #1344

kurnevsky opened this issue Aug 7, 2019 · 9 comments
Labels
doc An issue with or an improvement to documentation.

Comments

@kurnevsky
Copy link

What version of ripgrep are you using?

ripgrep 11.0.2
-SIMD -AVX (compiled)
+SIMD +AVX (runtime)

How did you install ripgrep?

Linux package.

What operating system are you using ripgrep on?

Arch Linux

Describe your question, feature request, or bug.

--hidden doesn't work with --type all

If this is a bug, what are the steps to reproduce the behavior?

Search something contained in project's hidden files (starting with dot) with both --hidden and --type all flags.

If this is a bug, what is the actual behavior?

It won't be found.

If this is a bug, what is the expected behavior?

It should be found.

@BurntSushi
Copy link
Owner

Please provide a reproduction. As the issue template requests:

If possible, please include both your search patterns and the corpus on which
you are searching.

@BurntSushi BurntSushi added the question An issue that is lacking clarity on one or more points. label Aug 7, 2019
@kurnevsky
Copy link
Author

mkdir /tmp/1
cd /tmp/1
echo qwerty > .env
rg --hidden qwerty
rg --hidden --type all qwerty

@kurnevsky
Copy link
Author

Hm... Just realized that it's filtered by extension .env. So even file name.env won't be shown. Is it expected to happen?

@kurnevsky
Copy link
Author

It seems --type all means all supported extensions - couldn't find it in the docs so was confused about it. Sorry for bothering.

@BurntSushi BurntSushi added doc An issue with or an improvement to documentation. and removed question An issue that is lacking clarity on one or more points. labels Aug 7, 2019
@BurntSushi
Copy link
Owner

Indeed, the special all type does not appear in the man page. That should be fixed, so I'm re-opening this. Thanks!

@BurntSushi BurntSushi reopened this Aug 7, 2019
@telotortium
Copy link
Contributor

Hi, could you add this to the documentation? I was confused about --type all wasn't searching all of my non-ignored files and couldn't find anything about it until now.

@BurntSushi
Copy link
Owner

@telotortium Yes. This ticket is marked as doc bug.

@BurntSushi
Copy link
Owner

@telotortium It would be helpful if you could write out the blurb in the docs that would have helped you! Thanks.

@telotortium
Copy link
Contributor

Hi @BurntSushi I gave it a shot in PR #1472 - thanks for getting back to me!

BurntSushi pushed a commit that referenced this issue Feb 16, 2020
This adds it to the guide and the docs for the --type flag.

Fixes #1344, Closes #1472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc An issue with or an improvement to documentation.
Projects
None yet
Development

No branches or pull requests

3 participants