Update update_players.py

[greatdansby]

Limited player name split to 1 comma, so an error doesn't occur for players with 2 commas. (Ex. Smith, John, Jr.)

[leighlondon]

Wouldn't this render their full name as "John, Jr. Smith"?

[greatdansby]

Yea, it's pretty inelegant, but it prevents an error around a data-point that (I believe) is only used for display. Unfortunately NFL.com isn't consistent with their commas (see Odell Beckham vs. Jame Wilder vs. Gerald Dixon). Maybe anything after the 2nd comma should be dropped altogether?

[ochawkeye]

Maybe anything after the 2nd comma should be dropped altogether?

I have to agree that solution would be more elegant than having a player like `Dixon, Gerald, Jr." end up with a first name like "Gerald, Jr.".

Can either capture only the first and second items:

last_name, first_name = map(lambda s: s.strip(), name.split(','))[:2]

Alternatively, could capture everything. Would work just fine with the code today but the full name assembling could be updated to handle these additional groups of items.

(last_name, first_name), more_name = map(lambda s: s.strip(), name.split(','))[:2], map(lambda s: s.strip(), name.split(','))[2:]

[BurntSushi]

I'm not seeing this error when running the update players script.

[ochawkeye]

This one was legit, but the last offender Gerald Dixon, Jr. seems to have been cleaned up on NFL.com in the past two weeks with a name "change" to Gerald Dixon Jr.

Don't know if it was causing problems on the NFL side which triggered the change or not. But I think it's probably fair to anticipate inconsistencies in the future.

[BurntSushi]

Yeah, the player data tends to go through a rough patch in the offseason.

I'm going to close this for now and hopefully I'll be more on top of things the next time this happens.