Proposal for Py2/3 Support #121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to work on nfldb now, as that is a better interface. (btw, it's for a plugin for this bot I am writing: https://github.com/datamachine/telegram-pybot) Edit: Scratch that, not that it isn't better, but I can't add postgres as a dependency. Is sqlite support out of the question? I wouldn't mind investigating supporting both. |
Conflicts: nflgame/schedule.json setup.py
|
Rebased on new changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested it in 2.7 and 3.4, mostly. I don't have a good test set, as I'm just starting to use it for a new Py3 project (which was my motivation for porting this), so I don't know it well. Also, not sure if there's a reason for using distutils over setuptools, but I love the "develop" support in setuptools, so I threw it in, we can always back that out.