If there are no ids to fill, don't run a query.

This is important, because running the query without ids can result in a retrieval of the full table.
BurntSushi · Aug 14, 2014 · 802db82 · 802db82
1 parent 4c6eac1
commit 802db82
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/nfldb/types.py b/nfldb/types.py
@@ -136,6 +136,8 @@ def pkval(entobj):
 
  import nfldb.query
  ids = list(set(pkval(obj) for obj in to_fill))
+ if len(ids) == 0:
+ return
  objs = nfldb.query._entities_by_ids(db, fill_with, *ids)
  byid = dict([(pkval(obj), obj) for obj in objs])
  for obj in to_fill: