Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format: Apply Black formatter to the codebase #127

Merged
merged 11 commits into from
Mar 11, 2024
Merged

format: Apply Black formatter to the codebase #127

merged 11 commits into from
Mar 11, 2024

Conversation

VitaminB16
Copy link
Contributor

@VitaminB16 VitaminB16 commented Mar 9, 2024

Applied Black formatter to the codebase.

All logic is completely untouched, but some small juggling was made in some places to reduce the number of lines.

Also added text to the error messages (for logger.error(err)).

I hope this number of changes does not mess up anything you are working on at the moment, though it should be modular enough to make merging easier.

@cullenwatson
Copy link
Member

cullenwatson commented Mar 10, 2024

Is there a script we could add to format the code before any commits?

@VitaminB16
Copy link
Contributor Author

Yes it is possible with a pre-commit, I can add a commit for it now

@VitaminB16
Copy link
Contributor Author

Now to use this pre-commit the developer needs to install it using pre-commit install. Then if a changed file is not formatted correctly, pre-commit will add the formatted files as unstaged changes, which will need to be staged and recommitted.

@cullenwatson cullenwatson merged commit 94d8f55 into Bunsly:main Mar 11, 2024
@cullenwatson
Copy link
Member

sick!!

@VitaminB16 VitaminB16 deleted the format-black branch March 11, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants