Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support all ast nodes for else case and normal case #1481

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Jun 12, 2024

Description

Fixes all cases of conditional render of Show and inlined expressions

fixes #1080

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 11e729a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

nx-cloud bot commented Jun 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 11e729a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

cloudflare-workers-and-pages bot commented Jun 12, 2024

Deploying mitosis with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6e6d95
Status: ✅  Deploy successful!
Preview URL: https://eb60a932.mitosis-9uh.pages.dev
Branch Preview URL: https://fix-conditions-show.mitosis-9uh.pages.dev

View logs

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@samijaber samijaber enabled auto-merge (squash) June 12, 2024 16:34
@samijaber samijaber disabled auto-merge June 12, 2024 19:58
@samijaber samijaber merged commit 2c1b162 into main Jun 12, 2024
8 checks passed
@samijaber samijaber deleted the fix-conditions-show branch June 12, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strings are not supported in the Show tag else, only tags are supported
2 participants