Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datasources not getting updated correctly #2480

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

kevmodrome
Copy link
Contributor

Description

Fixes an issue where only the name would be saved and everything else would be thrown out when updating a datasource.

@codecov-commenter
Copy link

Codecov Report

Merging #2480 (ab77935) into develop (f0bebb0) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2480      +/-   ##
===========================================
+ Coverage    74.79%   74.80%   +0.01%     
===========================================
  Files          111      111              
  Lines         3384     3386       +2     
  Branches       475      475              
===========================================
+ Hits          2531     2533       +2     
  Misses         556      556              
  Partials       297      297              
Impacted Files Coverage Δ
packages/server/src/api/controllers/datasource.js 62.12% <0.00%> (ø)
packages/server/src/api/controllers/table/utils.js 81.55% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a24afb7...ab77935. Read the comment docs.

@kevmodrome kevmodrome merged commit cce126c into develop Aug 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2021
@adrinr adrinr deleted the fix/datasource-updates branch August 29, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants