Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the NPS Feedback Form options and comments optional #2317

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

kevmodrome
Copy link
Contributor

Description

Makes the NPS Feedback Form options and comments optional

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #2317 (dc0fd3f) into develop (25a737a) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2317      +/-   ##
===========================================
- Coverage    75.22%   75.17%   -0.06%     
===========================================
  Files          112      111       -1     
  Lines         3338     3363      +25     
  Branches       463      472       +9     
===========================================
+ Hits          2511     2528      +17     
- Misses         534      540       +6     
- Partials       293      295       +2     
Impacted Files Coverage Δ
...es/server/src/automations/steps/outgoingWebhook.js 72.41% <0.00%> (-10.92%) ⬇️
packages/server/src/utilities/workerRequests.js 33.84% <0.00%> (-1.64%) ⬇️
packages/server/src/db/utils.js 78.72% <0.00%> (-1.50%) ⬇️
packages/server/src/api/controllers/dev.js 25.92% <0.00%> (-0.49%) ⬇️
packages/server/src/db/client.js 93.75% <0.00%> (ø)
packages/server/src/utilities/global.js 85.36% <0.00%> (ø)
packages/server/src/api/routes/hosting.js 100.00% <0.00%> (ø)
packages/server/src/api/controllers/apikeys.js 100.00% <0.00%> (ø)
...kages/server/src/api/controllers/view/exporters.js 100.00% <0.00%> (ø)
packages/server/src/db/builder.js
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb5284...dc0fd3f. Read the comment docs.

@kevmodrome
Copy link
Contributor Author

Unsure why this would fail - does it fail on other branches as well?

@shogunpurple
Copy link
Member

@kevmodrome seems like the develop branch is green. Might just be a flaky cypress test perhaps

@kevmodrome
Copy link
Contributor Author

Re-running to see if it passes 🙏

@kevmodrome kevmodrome merged commit 94e27e1 into develop Aug 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2021
@adrinr adrinr deleted the fix/make-feedbackform-comment-optional branch August 29, 2023 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants