-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the NPS Feedback Form modal/popup #2041
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2041 +/- ##
========================================
Coverage 75.80% 75.80%
========================================
Files 112 112
Lines 3310 3310
Branches 458 458
========================================
Hits 2509 2509
Misses 513 513
Partials 288 288 Continue to review full report at Codecov.
|
@kevmodrome does the second modal have the same title at the first one? |
Good catch! Fixed now. |
@kevmodrome nice one! One little design nitpick: And, on top of that, maybe replace the word Page with Step. |
Fixed and uploaded new images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one question on the behaviour of it - since it uses cookies I think it's very likely that they'll see this pop up a few times. That's fine, but is there a way for them to easily dismiss it after they've already filled it in? I don't see a close icon or button, but does it go away with a click outside?
Good q! There's currently no way to dismiss it, unsure what kind of UX @joebudi wants here? |
@aptkingston and @kevmodrome I don't think they (the users) should see it again, and again. It will get annoying imo. There should be an X to close the modal and it should disappear if they click elsewhere. We're asking for helpful information, but it should not upset the UX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
NAB: Would be nice to store in the db like Joe said to prevent seeing it again, but that could come as a follow up
@joebudi is this ok? |
Perfecto! |
Description
This PR adds #1736 to the builder. It shows up after the user has clicked the Preview/Play button to preview their app. It uses a feedbackSubmitted cookie to check if the user has already submitted feedback. As discussed in the issue it might make sense to have that attached directly on the user so that they won't see it multiple times if using different devices.
Screenshots