Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the NPS Feedback Form modal/popup #2041

Merged
merged 13 commits into from
Jul 22, 2021
Merged

Conversation

kevmodrome
Copy link
Contributor

@kevmodrome kevmodrome commented Jul 21, 2021

Description

This PR adds #1736 to the builder. It shows up after the user has clicked the Preview/Play button to preview their app. It uses a feedbackSubmitted cookie to check if the user has already submitted feedback. As discussed in the issue it might make sense to have that attached directly on the user so that they won't see it multiple times if using different devices.

Screenshots

CleanShot 2021-07-21 at 12 34 03@2x

CleanShot 2021-07-21 at 13 09 12@2x

CleanShot 2021-07-21 at 13 09 19@2x

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #2041 (9e34886) into develop (4aa1e42) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2041   +/-   ##
========================================
  Coverage    75.80%   75.80%           
========================================
  Files          112      112           
  Lines         3310     3310           
  Branches       458      458           
========================================
  Hits          2509     2509           
  Misses         513      513           
  Partials       288      288           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa1e42...9e34886. Read the comment docs.

@joebudi
Copy link
Contributor

joebudi commented Jul 21, 2021

@kevmodrome does the second modal have the same title at the first one?

@kevmodrome
Copy link
Contributor Author

@kevmodrome does the second modal have the same title at the first one?

Good catch! Fixed now.

@joebudi
Copy link
Contributor

joebudi commented Jul 21, 2021

@kevmodrome nice one! One little design nitpick:
Could you align the page detail with the buttons - Page 2 of 3 should be center-aligned with the preview and next button.

And, on top of that, maybe replace the word Page with Step.

@kevmodrome
Copy link
Contributor Author

@kevmodrome nice one! One little design nitpick:
Could you align the page detail with the buttons - Page 2 of 3 should be center-aligned with the preview and next button.

And, on top of that, maybe replace the word Page with Step.

Fixed and uploaded new images

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one question on the behaviour of it - since it uses cookies I think it's very likely that they'll see this pop up a few times. That's fine, but is there a way for them to easily dismiss it after they've already filled it in? I don't see a close icon or button, but does it go away with a click outside?

@kevmodrome
Copy link
Contributor Author

LGTM! Just one question on the behaviour of it - since it uses cookies I think it's very likely that they'll see this pop up a few times. That's fine, but is there a way for them to easily dismiss it after they've already filled it in? I don't see a close icon or button, but does it go away with a click outside?

Good q! There's currently no way to dismiss it, unsure what kind of UX @joebudi wants here?

@joebudi
Copy link
Contributor

joebudi commented Jul 22, 2021

@aptkingston and @kevmodrome I don't think they (the users) should see it again, and again.

It will get annoying imo. There should be an X to close the modal and it should disappear if they click elsewhere.

We're asking for helpful information, but it should not upset the UX.

Copy link
Collaborator

@PClmnt PClmnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Rory-Powell Rory-Powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
NAB: Would be nice to store in the db like Joe said to prevent seeing it again, but that could come as a follow up

@kevmodrome
Copy link
Contributor Author

@joebudi is this ok?

CleanShot 2021-07-22 at 12 09 27@2x

@joebudi
Copy link
Contributor

joebudi commented Jul 22, 2021

@joebudi is this ok?

CleanShot 2021-07-22 at 12 09 27@2x

Perfecto!

@kevmodrome kevmodrome merged commit eb1b5c0 into develop Jul 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2021
@kevmodrome kevmodrome deleted the feature/nps-feedback-form branch July 23, 2021 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants