Fix typo. Fixes #683 #700
Merged
Fix typo. Fixes #683 #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also have this problem and this fix helped me. Merge please! Thanks a lot |
|
@asankov Please reflect changes to source code: https://github.com/Bttstrp/bootstrap-switch/blob/master/CONTRIBUTING.md |
|
@LostCrew in sources is this what is needed The existing test suite didn't catch this so I guess we need a test as well. |
asankov
force-pushed
the
options-typo
branch
3 times, most recently
from
b905e16
to
8133409
Compare
|
@LostCrew thanks for pointing me to the contribution guidelines. I haven't contributed to a js library before, so I am not familiar with the build process, etc. I updated my PR accordingly, can you take a look at it again? |
|
@LostCrew ping. can you take a look at this? It looks like a lot of people would benefit of merging this PR? |
amacou
pushed a commit
to amacou/bootstrap-switch
that referenced
this pull request
Jul 23, 2019
lavaturtle
added a commit
to controlshift/bootstrap-switch
that referenced
this pull request
Jul 30, 2019
…o we can use this direct from github This is a temporary measure until Bttstrp#700 is accepted upstream and a new version is released.
Apparently, this typo leads to a bug with the select button - it is ON, but displayed as OFF, because it is unable to iterate through the classes that muse be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, this typo leads to a bug with the select button - it is ON, but displayed as OFF, because it is unable to iterate through the classes that muse be set