Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove let #619

Merged
merged 1 commit into from
Feb 16, 2017
Merged

remove let #619

merged 1 commit into from
Feb 16, 2017

Conversation

graingert
Copy link
Collaborator

@graingert graingert commented Feb 16, 2017

const is better than let, and you never need to use let - if you think functionally enough.

@graingert graingert merged commit e60cae9 into develop Feb 16, 2017
@graingert graingert deleted the remove-let branch February 16, 2017 12:05
@LostCrew
Copy link
Member

@graingert Ok like that, but I'm not a fan of the ternary operator, especially in long expressions. Midly relatedly, I identify Math.round(Math.max(this.$on.width(), this.$off.width())) possibly being a separate function.

@LostCrew LostCrew self-assigned this Feb 25, 2017
@graingert
Copy link
Collaborator Author

graingert commented Feb 25, 2017 via email

@LostCrew
Copy link
Member

@graingert I'm adding stage-2 now, it might help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants