allow upward range of jquery versions #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allright, can you check if |
|
@LostCrew bower.json is fine as-is; just the peerDeps on npm need it. Cheers! |
|
Getting this in, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LostCrew Sorry for the delayed response, I wanted to verify my words before I responded...what I actually mean is using the
>=operator as opposed to the~. Apologies, I submitted a PR with the change if you agree.The benefit is that as long as the siblings require anything jquery 1.9.x and above, you will not throw errors for EPEERINVALID during install. The risk is following edge version of jquery and the consequences therein; however I am assuming you are mostly using basic selectors which shouldn't change.
Thanks for thinking on this. -Jonathan