Ensure to use full XML responses when testing serializers.

Bram-- · Mar 23, 2024 · 62b710a · 62b710a
1 parent 57fd1cc
commit 62b710a
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 9 deletions.
diff --git a/src/main/kotlin/org/audux/bgg/response/Collection.kt b/src/main/kotlin/org/audux/bgg/response/Collection.kt
@@ -135,7 +135,7 @@ data class Status(
  /** Whether item is currently owned. */
  @JacksonXmlProperty(isAttribute = true)
  @JsonFormat(pattern = "yyyy-MM-dd HH:mm:ss")
- @Serializable(with = LocalDateSerializer::class)
+ @Serializable(with = LocalDateTimeSerializer::class)
  val lastModified: LocalDateTime? = null,
 )
 

diff --git a/src/main/kotlin/org/audux/bgg/response/ForumList.kt b/src/main/kotlin/org/audux/bgg/response/ForumList.kt
@@ -76,6 +76,6 @@ data class ForumSummary(
  /** The date and time a post was last made. */
  @JsonFormat(pattern = "E, dd MMM yyyy HH:mm:ss Z")
  @JacksonXmlProperty(isAttribute = true)
- @Serializable(with = LocalDateSerializer::class)
+ @Serializable(with = LocalDateTimeSerializer::class)
  val lastPostDate: LocalDateTime?,
 )
diff --git a/src/test/kotlin/org/audux/bgg/response/CollectionResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/CollectionResponseTest.kt
@@ -40,7 +40,12 @@ class CollectionResponseTest {
  @Test
  fun `is (K)Serializable`() {
  val collection =
- mapper.readValue(TestUtils.xml("collection?username=empty"), Collection::class.java)
+ mapper.readValue(
+ TestUtils.xml(
+ "collection?username=novaeux&stats=1&subtype=boardgame&excludesubtype=boardgameexpansion"
+ ),
+ Collection::class.java
+ )
  val encodedCollection = Json.encodeToString(collection)
 
  assertThat(Json.decodeFromString<Collection>(encodedCollection)).isEqualTo(collection)

diff --git a/src/test/kotlin/org/audux/bgg/response/FamilyResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/FamilyResponseTest.kt
@@ -37,7 +37,7 @@ class FamilyResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val family = mapper.readValue(TestUtils.xml("family?id=-1"), Family::class.java)
+ val family = mapper.readValue(TestUtils.xml("family"), Family::class.java)
  val encodedFamily = Json.encodeToString(family)
 
  assertThat(Json.decodeFromString<Family>(encodedFamily)).isEqualTo(family)

diff --git a/src/test/kotlin/org/audux/bgg/response/ForumListResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/ForumListResponseTest.kt
@@ -36,7 +36,7 @@ class ForumListResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val forumList = mapper.readValue(TestUtils.xml("forumlist?id=-1"), ForumList::class.java)
+ val forumList = mapper.readValue(TestUtils.xml("forumlist"), ForumList::class.java)
  val encodedForumList = Json.encodeToString(forumList)
 
  assertThat(Json.decodeFromString<ForumList>(encodedForumList)).isEqualTo(forumList)

diff --git a/src/test/kotlin/org/audux/bgg/response/GeekListResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/GeekListResponseTest.kt
@@ -37,7 +37,8 @@ class GeekListResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val geekList = mapper.readValue(TestUtils.xml("geeklist?id=331520"), GeekList::class.java)
+ val geekList =
+ mapper.readValue(TestUtils.xml("geeklist?id=331520&comments=1"), GeekList::class.java)
  val encodedGeekList = Json.encodeToString(geekList)
 
  assertThat(Json.decodeFromString<GeekList>(encodedGeekList)).isEqualTo(geekList)

diff --git a/src/test/kotlin/org/audux/bgg/response/GuildResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/GuildResponseTest.kt
@@ -53,7 +53,8 @@ class GuildResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val guild = mapper.readValue(TestUtils.xml("guilds?id=2310"), Guild::class.java)
+ val guild =
+ mapper.readValue(TestUtils.xml("guilds?id=2310&members=1&page=1"), Guild::class.java)
  val encodedGuild = Json.encodeToString(guild)
 
  assertThat(Json.decodeFromString<Guild>(encodedGuild)).isEqualTo(guild)

diff --git a/src/test/kotlin/org/audux/bgg/response/HotResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/HotResponseTest.kt
@@ -34,7 +34,7 @@ class HotResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val hotList = mapper.readValue(TestUtils.xml("hot?type=rpgperson"), HotList::class.java)
+ val hotList = mapper.readValue(TestUtils.xml("hot"), HotList::class.java)
  val encodedHotList = Json.encodeToString(hotList)
 
  assertThat(Json.decodeFromString<HotList>(encodedHotList)).isEqualTo(hotList)

diff --git a/src/test/kotlin/org/audux/bgg/response/UserResponseTest.kt b/src/test/kotlin/org/audux/bgg/response/UserResponseTest.kt
@@ -36,7 +36,11 @@ class UserResponseTest {
 
  @Test
  fun `is (K)Serializable`() {
- val user = mapper.readValue(xml("user?name=Novaeux"), User::class.java)
+ val user =
+ mapper.readValue(
+ xml("user?name=Novaeux&buddies=1&hot=1&top=1&guilds=1&page=1&domain=boardgame"),
+ User::class.java
+ )
  val encodedUser = Json.encodeToString(user)
 
  assertThat(Json.decodeFromString<User>(encodedUser)).isEqualTo(user)