Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ip adresses (and some other special characters) in a regex matching adb devices output #70

Merged
merged 6 commits into from
Feb 24, 2022

Conversation

zeerooth
Copy link
Contributor

Should resolve #69

@zeerooth zeerooth added status: needs review A maintainer must review this code target: Android labels Feb 23, 2022
Copy link
Contributor

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Thanks so much for adding tests!)

src/android/adb/device_list.rs Outdated Show resolved Hide resolved
src/android/adb/device_list.rs Outdated Show resolved Hide resolved
src/android/adb/device_list.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@francesca64 francesca64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, as always!

@francesca64 francesca64 merged commit 5395f1a into master Feb 24, 2022
@zeerooth zeerooth deleted the resolve-issue-69 branch March 11, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review A maintainer must review this code target: Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not list connected android devices
2 participants